Shorten client:check and service:check output in CI #1404
Conversation
|
Waiting for DefinitelyTyped/DefinitelyTyped#36924 for correct types here |
|
@evans I put this behind a flag, we could also have this be automatic when the |
jgzuke
force-pushed
the
jgzuke/hide-some-cli-output
branch
from
9bd143a to
7ba2314
Compare
jgzuke
force-pushed
the
jgzuke/hide-some-cli-output
branch
from
c2bbf5b to
9f7322b
Compare
evans
left a comment
evans
left a comment
There was a problem hiding this comment.
I appreciate the changes! I agree with your comment about automatically setting compact output for ci. The isCI flag from https://github.com/pvdlg/env-ci#readme seems like the ticket! What are you thinking with the implementation, ie this PR or a separate?
Regardless of what we do, dogfooding the compact output within this repository would give me the confidence to approve this PR, knowing that the output works and is useful for ci environments.
Also what's your plan with documentation?
jgzuke
force-pushed
the
jgzuke/hide-some-cli-output
branch
from
9f7322b to
432a36d
Compare
jgzuke
changed the title
jgzuke
changed the title
|
@evans https://circleci.com/gh/apollographql/apollo-tooling/28699 vs https://circleci.com/gh/apollographql/apollo-tooling/28534 for the output difference |
jgzuke
force-pushed
the
jgzuke/hide-some-cli-output
branch
from
cd7c231 to
0560aa1
Compare
jgzuke
force-pushed
the
jgzuke/hide-some-cli-output
branch
from
3054078 to
0cfceaf
Compare
evans
left a comment
evans
left a comment
There was a problem hiding this comment.
Thank you for putting this together! For a second I was curious how the CompactRender interacts with DEBUG=* apollo service:check and then realized that most users will be running the DEBUG command from their local terminals, so it's a non-issue.
I also recommend thinking about splitting check.test.ts out into two files, one for service and client. Since they depend on a remote server, my hunch is they are the longest tests. Up to you and depends on if they actually are the most time intensive.
Approved, since ^ isn't blocking!
|
|
||
| nock.disableNetConnect(); | ||
|
|
||
| delete process.env.CI; |
There was a problem hiding this comment.
re these lines, I think this is a fine solution. Not sure there's a more effective way to simulate this environment
* Add compact renderer behind flag * listr types * type fixes * type fixes * update CHANGELOG * Replace flag with isCi check * Make client:check compact in CI * Update CHANGELOG * Remove extra changes * Fix CI resetting
2 participants
TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.