Only activate extension on apollo.config.js/ts#1411
Merged
JakeDawkins merged 4 commits intomasterfrom Jul 18, 2019
Merged
Conversation
Contributor
|
@trevor-scheer I can't get this version of the extension to activate anywhere, in any project after building/installing it. |
essaji
pushed a commit
to essaji/apollo-tooling
that referenced
this pull request
Aug 25, 2019
* Only activate extension on apollo.config.js/ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Activating the extension on
package.jsonis potentially obnoxious for non-apollo projects, and breaks for projects that don't use a package file. Activating onapollo.config.jsworks across all project types and keeps the extension quiet for non-apollo projects.TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.