Skip to content

Only activate extension on apollo.config.js/ts#1411

Merged
JakeDawkins merged 4 commits intomasterfrom
trevor/vscode-activation
Jul 18, 2019
Merged

Only activate extension on apollo.config.js/ts#1411
JakeDawkins merged 4 commits intomasterfrom
trevor/vscode-activation

Conversation

@trevor-scheer
Copy link
Copy Markdown
Contributor

@trevor-scheer trevor-scheer commented Jul 17, 2019

Activating the extension on package.json is potentially obnoxious for non-apollo projects, and breaks for projects that don't use a package file. Activating on apollo.config.js works across all project types and keeps the extension quiet for non-apollo projects.

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@JakeDawkins
Copy link
Copy Markdown
Contributor

@trevor-scheer I can't get this version of the extension to activate anywhere, in any project after building/installing it.

@JakeDawkins JakeDawkins merged commit e700ffa into master Jul 18, 2019
@JakeDawkins JakeDawkins deleted the trevor/vscode-activation branch July 18, 2019 16:26
essaji pushed a commit to essaji/apollo-tooling that referenced this pull request Aug 25, 2019
* Only activate extension on apollo.config.js/ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants