Skip to content

Fix config path parsing with ts files#1463

Merged
JakeDawkins merged 2 commits intomasterfrom
jake/fix-ts-config-path
Aug 7, 2019
Merged

Fix config path parsing with ts files#1463
JakeDawkins merged 2 commits intomasterfrom
jake/fix-ts-config-path

Conversation

@JakeDawkins
Copy link
Copy Markdown
Contributor

resolves #881

Previously, when initializing an ApolloConfig class, we were pulling the dirname properly off the file path of a .js config file, but we weren't handling the case of the config filepath being a .ts file at all (oops).

This change should fix the dirname parsing for all files that we support.

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@JakeDawkins JakeDawkins merged commit 9c94fd0 into master Aug 7, 2019
@JakeDawkins JakeDawkins deleted the jake/fix-ts-config-path branch August 7, 2019 13:52
essaji pushed a commit to essaji/apollo-tooling that referenced this pull request Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

client:codegen failing when run with npx/yarn

1 participant