Error with duplicate operation names#1466
Merged
JakeDawkins merged 4 commits intomasterfrom Aug 15, 2019
Merged
Conversation
JakeDawkins
changed the title
justinanastos
previously requested changes
Aug 13, 2019
JakeDawkins
force-pushed
the
jake/warn-duplicate-operations
branch
from
f3aa26a to
68b2a5f
Compare
essaji
pushed a commit
to essaji/apollo-tooling
that referenced
this pull request
Aug 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
apollo-language-serverrequires operation names in a client project to be unique in order to properly generate types, but this isn't enforced by an error. This PR adds an error so the user is aware of a name collision.When generating a type using codegen, if there are duplicate type names, only one of the operations will get types generated. this error will enforce the already designed intention of the CLI.
The following screenshot shows the error as well as showing that the error doesn't interfere with
--watchmode.resolves #1427
TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.