Support federated service:check/push with local schema file#1489
Merged
JakeDawkins merged 7 commits intomasterfrom Oct 1, 2019
Merged
Support federated service:check/push with local schema file#1489JakeDawkins merged 7 commits intomasterfrom
JakeDawkins merged 7 commits intomasterfrom
Conversation
41ba7d9 to
f8f8c3a
Compare
1b6c2a6 to
192152e
Compare
jbaxleyiii
approved these changes
Sep 19, 2019
- apollo-codegen-core@0.36.0-alpha.0 - apollo-codegen-flow@0.34.0-alpha.0 - apollo-codegen-scala@0.35.0-alpha.0 - apollo-codegen-swift@0.36.0-alpha.0 - apollo-codegen-typescript@0.36.0-alpha.0 - apollo-language-server@1.16.0-alpha.0 - apollo@2.19.0-alpha.0 - vscode-apollo@1.11.0-alpha.0
30419c4 to
e0fb3c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, the only way to
push/checka federated service is to use the--endpointoption and query the_service { sdl }. This is difficult to do in CI workflows because of other dependencies services may need in order to start up.This PR adds the ability to specify a
--localSchemaFileto use as a source of thesdlinstead of querying a running service.Constraints
localSchemaFilemust be a graphql file. The file used is interpreted as plain text and it passed directly to the check/push mutation, so anything file extensions other thangraphql,gql, andgraphqlswill be errored.Other
sdlis now the only thing that's being queried from running services instead of theurlandname, thefederation-infoproviders aren't needed. The logic for loading the sdl can fit inside the existing schema providers.introspectionschema provider toendpointsince now there's more being fetched from an endpoint than the introspection query (_service { sdl })usage
For the CLI, you can now use the
--localSchemaFileflag to point to sdlYou can also add the file path in the config file to avoid using the flag
Along with client projects, the
localSchemaFilealso supports multiple valuesIn the apollo config file:
as a CLI flag:
--localSchemaFile=schema.graphql,schema2.graphqlTODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.