Merged
Conversation
designatednerd
referenced
this pull request
in apollographql/apollo-ios
Sep 16, 2019
This reverts commit c485878.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of how oclif handles flags, it was possible to incorrectly parse a command with multiple
--localSchemaFileflags like the following:apollo client:codegen --target=swift --localSchemaFile=schema.graphql API.swiftThis command would parse the last
<output>argument as a schema and fail to parse. This is a bug that currently exists in oclif with howmultiple: trueflags are parsed.oclif/oclif#190 (comment)
This PR changes flag parsing to only accept a single flag for
localSchemaFile, allowing for a comma-separated-list of schema files like:TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.