Install graphql-js into devDependencies at the monorepo level.#1542
Install graphql-js into devDependencies at the monorepo level.#1542
graphql-js into devDependencies at the monorepo level.#1542Conversation
Currently, even though most of this repository currently specifies `graphql` as a peer-dependency, the only reason it's installed at the monorepo root, and thus available for use by all packages, is because it's a direct dependency of `apollo` and `apollo-language-server`. This is causing it not to be upgraded to the most recent version by Renovate. In my own case, I needed the latest version for TypeScript typings for `PossibleTypeExtensions` which were not ever officially published in the DefinitelyTyped typings (likely due to the method being experimental) but are now part of the `graphql` package itself thanks to the work that @JacksonKearl did.
|
Test failures seem legitimate! Though I'll have to circle back to this later, so I'll close this for now. |
|
@abernix is this change still of interest? Rather, what's the reason for closing? |
|
@trevor-scheer I’d appreciate your input on it, I mainly didn’t want to clog up the PR queue with something I hadn’t really had time to look into at all. I do have another branch which depends on this change for the typings. But I could also feel okay opening that branch with a ts-ignore. Input appreciated though, if you have time! |
251f339 to
186e381
Compare
|
@abernix this should be good to go now! There was a TS error that resolved the build issues, here:
I also removed the |
|
Removing the |
Currently, even though most of this repository currently specifies
graphqlas a peer-dependency, the only reason it's installed at the monorepo root, and thus available for use by all packages, is because it's a direct dependency ofapolloandapollo-language-server.This is causing it not to be upgraded to the most recent version by Renovate. In my own case, I needed the latest version for TypeScript typings for
PossibleTypeExtensionswhich were not ever officially published in the DefinitelyTyped typings (likely due to the method beingexperimental) but are now part of the
graphqlpackage itself thanks to thework that @JacksonKearl did.