Fix debouncing issue in vscode autocomplete#1593
Merged
JakeDawkins merged 2 commits intomasterfrom Oct 17, 2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an incremental improvement to the autocomplete handling in the language server. this is not a 100% fix for all of the issues in autocomplete but hopefully is a complete fix for the ctrl+space recommendations in vscode.
Ctrl+space and autocomplete right now doesn't work properly. The recommended options are showing the fields for the parent type.
This is because of the
leading: falseoption being passed to the debounce function. In addition, this PR reduces the debounce timeout to make other issues with autocomplete less obviousTODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.