Skip to content

Modify styling of CLI output#1598

Merged
zionts merged 4 commits intomasterfrom
adam/19/10/colors
Oct 24, 2019
Merged

Modify styling of CLI output#1598
zionts merged 4 commits intomasterfrom
adam/19/10/colors

Conversation

@zionts
Copy link
Copy Markdown
Contributor

@zionts zionts commented Oct 18, 2019

Specifically, replace all instances of chalk.blue with chalk.cyan, which
is more readable in dark mode (the green color we use is basically
unreadable in light mode anyway)

Additionally, this changes some spacing of the service:list command to
allow users to see the URL to navigate to more obviously.

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@JakeDawkins
Copy link
Copy Markdown
Contributor

I think the only concerning thing is that the cyan is less visible on a white bg, than the blue. But I think the cyan-white combo is more visible than the blue-black combo, and since the majority of people use dark terminals, I think this is an okay tradeoff.

Just a couple screenshots to show the differences here :)

Before/after with black bg

Screen Shot 2019-10-18 at 10 35 22 AM

Screen Shot 2019-10-18 at 10 35 55 AM

Before/after with a white bg

Screen Shot 2019-10-18 at 10 46 50 AM

Screen Shot 2019-10-18 at 10 35 33 AM

@zionts
Copy link
Copy Markdown
Contributor Author

zionts commented Oct 18, 2019

thanks for attaching the screenshots @JakeDawkins ! Maybe @daniman wants to mess around with colors too 👀

@JakeDawkins
Copy link
Copy Markdown
Contributor

@zionts @daniman maybe a solution would be to use background colors in tandem with foregrounds? that way, we know the background color and the foreground color so we don't run into any theme issues with terminals? Just a thought, it could look clunky

@zionts
Copy link
Copy Markdown
Contributor Author

zionts commented Oct 21, 2019

@JakeDawkins I found that background colors looked super clunky, unfortunately :/ Ideally, there'd be a library that takes into account the users' theme, but in lieu of that, I think this is an improvement!

@JakeDawkins
Copy link
Copy Markdown
Contributor

@zionts gotcha, gotcha. I think another alternative is to try to set colors as best as we can, but allow a --noColor or -n flag to disable colors and instead set the text to bold for users whose themes are still unreadable.

I think since people can adjust their color palettes all over the place, we may not be able to fully ensure readability.

Adam Zionts added 3 commits October 24, 2019 12:42
Specifically, replace all instances of chalk.blue with chalk.cyan, which
is more readable in dark mode (the green color we use is basically
unreadable in light mode anyway)

Additionally, this changes some spacing of the service:list command to
allow users to see the URL to navigate to more obviously.
@zionts zionts force-pushed the adam/19/10/colors branch from 50abd00 to ea3d35e Compare October 24, 2019 19:43
@zionts zionts merged commit ff02fd0 into master Oct 24, 2019
@zionts zionts deleted the adam/19/10/colors branch October 24, 2019 20:22
caydie-tran pushed a commit that referenced this pull request Nov 8, 2019
* Update styles in commands

Specifically, replace all instances of chalk.blue with chalk.cyan, which
is more readable in dark mode (the green color we use is basically
unreadable in light mode anyway)

Additionally, this changes some spacing of the service:list command to
allow users to see the URL to navigate to more obviously.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants