Conversation
|
I think the only concerning thing is that the cyan is less visible on a white bg, than the blue. But I think the cyan-white combo is more visible than the blue-black combo, and since the majority of people use dark terminals, I think this is an okay tradeoff. Just a couple screenshots to show the differences here :) Before/after with black bg Before/after with a white bg |
|
thanks for attaching the screenshots @JakeDawkins ! Maybe @daniman wants to mess around with colors too 👀 |
|
@JakeDawkins I found that background colors looked super clunky, unfortunately :/ Ideally, there'd be a library that takes into account the users' theme, but in lieu of that, I think this is an improvement! |
|
@zionts gotcha, gotcha. I think another alternative is to try to set colors as best as we can, but allow a I think since people can adjust their color palettes all over the place, we may not be able to fully ensure readability. |
Specifically, replace all instances of chalk.blue with chalk.cyan, which is more readable in dark mode (the green color we use is basically unreadable in light mode anyway) Additionally, this changes some spacing of the service:list command to allow users to see the URL to navigate to more obviously.
50abd00 to
ea3d35e
Compare
* Update styles in commands Specifically, replace all instances of chalk.blue with chalk.cyan, which is more readable in dark mode (the green color we use is basically unreadable in light mode anyway) Additionally, this changes some spacing of the service:list command to allow users to see the URL to navigate to more obviously.




Specifically, replace all instances of chalk.blue with chalk.cyan, which
is more readable in dark mode (the green color we use is basically
unreadable in light mode anyway)
Additionally, this changes some spacing of the service:list command to
allow users to see the URL to navigate to more obviously.
TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.