Fix client localSchemaFile for vscode stats command#1634
Merged
JakeDawkins merged 2 commits intomasterfrom Nov 19, 2019
Merged
Conversation
Contributor
|
Can we tell if there's another configuration path where Boolean((this.serviceID || this.localSchemaFile) && (this.schema || this.serviceSchema))This is just a stab / guess. |
Contributor
Author
|
@trevor-scheer I can check, but since this is only used for logging output to vscode, I don't think that'd matter. I tried something similar to what you dropped in but TS was v. angry 🙃 |
trevor-scheer
approved these changes
Nov 6, 2019
0508578 to
c669f3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if you click on the Apollo logo on the status bar, stats for the project you're working with are supposed to show, to confirm the config was setup properly and the extension has loaded.
If you're setting up a client project and using a
localSchemaFilethough, the stats will fail to load unless there is a servicenamealso provided, which isn't required.This removes the check in the stats loading function that forced a client to have a
client.service.nameeven if not using graph manager to load the schema.TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.