[fix] add @types/node-fetch as a devDependency to apollo-env#1701
Closed
lookfirst wants to merge 1 commit intoapollographql:masterfrom
Closed
[fix] add @types/node-fetch as a devDependency to apollo-env#1701lookfirst wants to merge 1 commit intoapollographql:masterfrom
lookfirst wants to merge 1 commit intoapollographql:masterfrom
Conversation
fixes apollographql#1686 I went with this instead of going to v3 of node-fetch because I didn't want to mess with changing to a major version.
Contributor
|
Thanks for taking a look @lookfirst, I've landed a fix here: #1749 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1686
I went with this instead of going to v3 of node-fetch because I didn't want to mess with changing to a major version.
One question I have is why this change isn't breaking the release build somewhere.... cause this is breaking my build now. =(
TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.