Add errors for 404 and HTML responses#1713
Merged
JakeDawkins merged 3 commits intomasterfrom Dec 9, 2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two of the most common errors that people encounter in the CLI and VS Code extension revolve around introspecting of schemas.
localSchemaFileare provided, the language server relies on the default endpointhttp://localhost:4000. If there is no server running there, it will 404. If the user has a service to run there (or anywhere else) but forgets to start it up, it will also 404. This PR adds an error for both of those cases. If the URL IS the default one, it will provide info about that.TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.