Update "no service found to link..." error#1847
Merged
JakeDawkins merged 3 commits intomasterfrom Mar 25, 2020
Merged
Conversation
Contributor
Author
|
Before: After: |
This updates the error message that occurs when a config.service.name is required in order to execute a command. Before this commit, there were two distinct messages that were used in commands to communicate this error to the user, which were slightly different in their wording. This updates the wording to provide an explanation as well as next steps on how to remedy the issue. Additionally, it uses the `CLIError` class in order to print out an error in a "friendly" way without a stack trace, as recommended by the @oclif/errors package we are using: https://oclif.io/docs/commands#thiserrormessage-string--error-options-code-string-exit-number
zionts
force-pushed
the
adam/20/3/no-graph-found-error
branch
from
dbcd274 to
a65872f
Compare
Contributor
Author
|
Update -- Added a commit (that we can revert if we'd like) that makes the error message split with newlines instead of spaces. This makes it more likely to fit in your shell: |
4 tasks
JakeDawkins
reviewed
Mar 25, 2020
JakeDawkins
reviewed
Mar 25, 2020
Co-Authored-By: Jake Dawkins <dawkinsjh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the error message that occurs when a config.service.name is
required in order to execute a command. Before this commit, there were
two distinct messages that were used in commands to communicate this
error to the user, which were slightly different in their wording. This
updates the wording to provide an explanation as well as next steps on
how to remedy the issue. Additionally, it uses the
CLIErrorclass inorder to print out an error in a "friendly" way without a stack trace,
as recommended by the @oclif/errors package we are using: https://oclif.io/docs/commands#thiserrormessage-string--error-options-code-string-exit-number
For changelog entry, please see #1849
TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.