Remove "hidden: true" from variant flag in service:push#1865
Merged
JakeDawkins merged 1 commit intomasterfrom Apr 2, 2020
Merged
Remove "hidden: true" from variant flag in service:push#1865JakeDawkins merged 1 commit intomasterfrom
JakeDawkins merged 1 commit intomasterfrom
Conversation
zionts
reviewed
Apr 1, 2020
Contributor
zionts
left a comment
zionts
left a comment
There was a problem hiding this comment.
This looks great! Thank you for making this fix.
Contributor
|
FWIW I don't think this needs a changelog entry. |
zionts
approved these changes
Apr 1, 2020
JakeDawkins
approved these changes
Apr 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
npx apollo service:push --help, there is no entry for--variant, due tohidden: truebeing used in the options for the flag (#1849). This PR removes thehidden: true.TODO: