Skip to content

Update deprecation message of ENGINE_API_KEY to include alternative of APOLLO_KEY#1866

Merged
JakeDawkins merged 1 commit intomasterfrom
adam/20/4/deprecation-warning-message-update
Apr 2, 2020
Merged

Update deprecation message of ENGINE_API_KEY to include alternative of APOLLO_KEY#1866
JakeDawkins merged 1 commit intomasterfrom
adam/20/4/deprecation-warning-message-update

Conversation

@zionts
Copy link
Copy Markdown
Contributor

@zionts zionts commented Apr 1, 2020

The message that appeared for users using ENGINE_API_KEY was not actionable before this change. This updates the message to suggest using APOLLO_KEY in lieu of ENGINE_API_KEY :)

I don't think this kind of change really necessitates a CHANGELOG entry, but happy to add one if requested.

TODO:

  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@zionts zionts changed the title Update deprecation message to include alternative. Update deprecation message of ENGINE_API_KEY to include alternative of APOLLO_KEY Apr 1, 2020
@zionts zionts requested a review from JakeDawkins April 1, 2020 20:23
@JakeDawkins JakeDawkins merged commit 9690cba into master Apr 2, 2020
@JakeDawkins JakeDawkins deleted the adam/20/4/deprecation-warning-message-update branch April 2, 2020 13:51
@JakeDawkins
Copy link
Copy Markdown
Contributor

Thanks @zionts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants