Don't error when ENGINE_API_KEY and APOLLO_KEY are found#1893
Merged
JakeDawkins merged 4 commits intomasterfrom Jun 3, 2020
Merged
Don't error when ENGINE_API_KEY and APOLLO_KEY are found#1893JakeDawkins merged 4 commits intomasterfrom
JakeDawkins merged 4 commits intomasterfrom
Conversation
zionts
approved these changes
Apr 13, 2020
Contributor
zionts
left a comment
There was a problem hiding this comment.
Works for me! I made a corresponding update to apollo server: apollographql/apollo-server@a83a1f5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apollo-serverstill uses theENGINE_API_KEY, so we can't truly move to the newer key. We have to be able to support both keys for now, so this removes the error and replaces it with a warning that explicitly states which key tooling is using.TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.