Fix silent codegen errors on syntax errors#1899
Merged
JakeDawkins merged 6 commits intomasterfrom Jun 3, 2020
Merged
Conversation
During document parsing, syntax errors are silently added to the document, but errors are never thrown. This PR checks at the _command-level_ for these errors and if they exist, prints them to the user. I didn't want to change at the document setup level, because I have a feeling the silent erroring was intention for the sake of the operation registry or something. So I added in an error where it was immediately causing an issue, in the client codegen command.
|
@JakeDawkins what's stopping you from merging that? Do you need help? |
Contributor
Author
|
Sorry for the hold-up @apieceofbart, it's been a while since I've had the time to even look at this 😅 After making a quick second-pass, I think this is safe to merge through |
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1897
During document parsing, syntax errors are silently
added to the document, but errors are never thrown.
This PR checks at the command-level for these errors
and if they exist, prints them to the user.
I didn't want to change at the document setup level, because
I have a feeling the silent erroring was intention for the sake
of the operation registry or something. So I added in an error
where it was immediately causing an issue, in the client
codegen command.
TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.