Change json-modern target to use legacy IR#1916
Merged
JakeDawkins merged 8 commits intomasterfrom May 6, 2020
Merged
Conversation
The legacy IR contains information that codegen in swift needs to work properly. When building the json-modern target, I didn't account for everything that was dropped from the original json output :sad:. This commit changes the json-modern codegen target so it uses the legacy IR generation with the exposeTypeNodes option set to true (which passes it to the new ir codegen since legacy uses that under the hood lol).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully resolves #1909
The legacy IR contains information that codegen in swift needs to
work properly. When building the json-modern target, I didn't
account for everything that was dropped from the original json
output :sad:. This commit changes the json-modern codegen target
so it uses the legacy IR generation with the exposeTypeNodes option
set to true (which passes it to the new ir codegen since legacy
uses that under the hood lol).
TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.