Export useful sanitizing functions: printWithReducedWhitespace, hideStringAndNumericLiterals and hideLiterals#2057
Merged
trevor-scheer merged 2 commits intoapollographql:masterfrom Nov 2, 2021
Conversation
Contributor
Author
|
It looks like there is a test that prevents me from updating the CHANGELOG: It seems to only allow the remote to be the |
569cf73 to
ca6c8a6
Compare
Contributor
|
Thanks @mcohen75, and sorry this took so long to get around to. I hope you don't mind, but I rebased your PR to get it all caught up and added a CHANGELOG entry. Thanks for expanding on the test cases! This is good to go 👍 |
trevor-scheer
approved these changes
Nov 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GraphQL execution requests can include PII. At Indeed we have need of a mechanism to sanitize requests of PII in order to maintain GDPR and CCPA requirements. I'm certain many other companies have this need, and expect this to also be useful for companies requiring HIPPA compliance.
The existing hideStringAndNumericLiterals and hideLiterals functions look to be well suited for this purpose. Here I've exported these functions, along with printWithReducedWhitespace which is a nice companion to both. I've updated the existing test for
hideLiteralsto cover more scenarios and added a test forhideStringAndNumericLiterals.