Swift Codegen: Split up appending of fragments to query document#2198
Conversation
Splits the appending of fragments to the query document into separate sub expressions to fix an issue where a query with lots of fragments caused the Swift type checker to fail.
|
@andybest: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
martijnwalraven
left a comment
There was a problem hiding this comment.
Thanks for the fix, this looks good to me. I wish we had tests that referenced more than one fragment, but since we're replacing codegen it may not be worth investing in that.
designatednerd
left a comment
There was a problem hiding this comment.
Apologies for the delay - I just tested the artifact from this against iOS. It does make some small changes in terms of how we concatenate fragment definitions, but I believe those should have a negligible impact on performance. I'll wait to merge this until Monday for "Seems like a bad weekend to deploy" reasons and then I'll cut a new version, add the new version to the iOS SDK, and cut a new version of that. Whee!
Splits the appending of fragments to the query document into separate
sub expressions to fix an issue where a query that references lots of fragments
causes the Swift type checker to fail with the following message:
TODO: