Conversation
abernix
left a comment
abernix
left a comment
There was a problem hiding this comment.
LGTM, though I'm not sure what to do about the README.md. 🤔
It's plausible to believe we could augment that oclif readme command with some apollo service: searchin' and replacing?
Notify users of the `service:*` commands that they have been deprecated, and point people towards Rover for replacement functionality.
Mostly to avoid the new service:* deprecation warnings, but also as an added bit of cleanup for previous console.log's that don't need to show.
It would have been great to add the full deprecation message to the top of the service:* command help output, but oclif will only allow one line to be shown in the description section of the help. As soon as it encounters a newline, it moves all subsequent content down into a DESCRIPTION section. To help with this, this commit prefixes each service:* description with [DEPRECATED] to make sure the deprecation notice is one of the first things people see. Then the full deprecation message is shown in the DESCRIPTION section.
|
@hwillson if I previously used apollo service:codegen, and Rover does not have it. What do I do? Is this functionality being removed in the next major release without any replacement in the Rover? |
|
@mindaugasnakrosis The |
|
@abernix I actually wrote a wrong command, my bad, however, the same question Downloads a schema from a graphql endpoint which I use to generate typescript typings I get an error: DEPRECATED: This command will be removed from the apollo CLI in I tried rover with graph download, however it downloads it in a different shape and format which I can not use to generate typescript typings, however maybe I have missed something? I followed this tutorial: https://www.apollographql.com/blog/tooling/apollo-codegen/typescript-graphql-code-generator-generate-graphql-types/ |
|
@mindaugasnakrosis I believe that |
4 participants
This PR deprecates the
apolloCLIservice:*commands by:stderr) deprecation messages for all runtimeapollo service:*commands (pointing people to the Rover migration guide)apollo service:*CLIhelpcommandsservice:*commands as deprecated in theREADMEservice:*functionality has not been removed since this PR will be rolled out in a patch release. After Rover is officially released, we’ll push out a new major version ofapollothat fully removes theservice:*commands.Reference: apollographql/rover#471