Add support for interface on interfaces to transformSchema#2456
Merged
hwillson merged 1 commit intoapollographql:masterfrom Oct 23, 2021
Merged
Add support for interface on interfaces to transformSchema#2456hwillson merged 1 commit intoapollographql:masterfrom
hwillson merged 1 commit intoapollographql:masterfrom
Conversation
59b5574 to
39b49ad
Compare
Member
|
Thanks for this @IvanGoncharov. The We're checking to make sure the It's very strange that |
hwillson
approved these changes
Oct 15, 2021
Member
hwillson
left a comment
There was a problem hiding this comment.
This looks great @IvanGoncharov - thanks!
…formSchema This change fixes `transformSchema`, which previously left `GraphQLInterface::interfaces` field as-is after transforming types. This meant that interfaces types used implemented by other interfaces would appear duplicated in the schema.
39b49ad to
8c579a2
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This change fixes
transformSchema, which previously leftGraphQLInterface::interfacesfield as-is after transforming types.This meant that interfaces types used implemented by other interfaces
would appear duplicated in the schema.
TODO: