Change generated flow files extension to .js instead of .ts#461
Merged
shadaj merged 1 commit intoapollographql:masterfrom Jun 29, 2018
TLadd:fix-flow-file-extension
Merged
Change generated flow files extension to .js instead of .ts#461shadaj merged 1 commit intoapollographql:masterfrom TLadd:fix-flow-file-extension
shadaj merged 1 commit intoapollographql:masterfrom
TLadd:fix-flow-file-extension
Conversation
Contributor
|
Good catch! Thanks for the PR! |
|
Just updated to apollo-codegen-flow@0.22.0, but the npm-published version doesn't seem to actually carry this change. @shadaj |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when the output to
apollo codegen:generateis not specified and the target is flow, all of the generated files have a .ts extension, but it should be .js.