Stop default flag values from overriding custom config#511
Stop default flag values from overriding custom config#511shadaj merged 1 commit intoapollographql:masterfrom
Conversation
klujanrosas
commented
Jul 24, 2018
- Check if a custom config for queries hasn't been setup, else fallback to flags.queries
|
@klujanrosas: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
|
I checked Travis and it tells me that |
|
Hi @klujanrosas! Allowing the However, we didn't catch that the queries would always be overriden by the default value. Maybe this could be fixed by only allowing overrides when the flag is not the default value? Also, we're aware of the Travis issue and will hopefully have a fix for it later today. |
|
Hi @shadaj , I went ahead and implemented your proposed solution. Thanks! |
30a9b8a to
fba0a23
Compare
|
@klujanrosas could you update with the latest master? We have another fix for the failing Travis issue that should make your changes pass. |
93d1eb6 to
4baac46
Compare
|
Thanks so much for the fix @klujanrosas! |