Skip to content

Preserve "data" and "__schema" keys when outputting JSON schema from schema:download#562

Merged
martijnwalraven merged 3 commits intoapollographql:masterfrom
jamesmbourne:schema-nesting-json
Aug 29, 2018
Merged

Preserve "data" and "__schema" keys when outputting JSON schema from schema:download#562
martijnwalraven merged 3 commits intoapollographql:masterfrom
jamesmbourne:schema-nesting-json

Conversation

@jamesmbourne
Copy link
Copy Markdown
Contributor

This resolves #555. The JSON schema generated by schema:download did not have a root node of:

"data": {
	"__schema" :{
		"queryType": ...
		...
	}
}

Snapshot tests for the output schema have been updated where appropriate.

@apollo-cla
Copy link
Copy Markdown

@jamesmbourne: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@martijnwalraven martijnwalraven merged commit afec48a into apollographql:master Aug 29, 2018
@martijnwalraven
Copy link
Copy Markdown
Contributor

Thanks a lot for fixing this, looks good to me!

martijnwalraven added a commit that referenced this pull request Aug 30, 2018
In contrast to #562, this no longer nests the introspection result under `data`, although it does preserve `__schema`.

Also see #555.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

schema:download generates incompatible schema JSON

3 participants