Restructure apollo queries:extract logic and manifest format.#611
Merged
Restructure apollo queries:extract logic and manifest format.#611
apollo queries:extract logic and manifest format.#611Conversation
As these commands continue to grow, it seems to make sense to also move their logic into a common tasks library.
…ations. While these assertions made less sense when every task was in the same file, a more composable approach to tasks begs for some general assertions to the context (`ctx`) that's being used.
I'm pretty sure there's a lot more to life than being really, really async.
jbaxleyiii
approved these changes
Oct 2, 2018
Contributor
jbaxleyiii
left a comment
jbaxleyiii
left a comment
There was a problem hiding this comment.
@trevor-scheer wanted to flag you on this one as it starts the breaking changes for 3.0 line and will need to be rebased into your work
This will allow the manifest to be more resilient against future changes by ensuring that the `version` is the most important attribute of its top-most level. Additionally, this includes the calculation of the signature which is used by Apollo Engine, in order to match operations up with each other.
abernix
force-pushed
the
abernix/relocate-common-tasks
branch
from
0869789 to
b254b3d
Compare
Member
Author
|
@trevor-scheer Happy to assist/adjust if this breaks anything you currently have in-flight. |
While I'm at breaking changes, we don't have a compelling enough reason to support SHA-512 just yet. The ask for 512 was previously my own since it could have a longer lifespan (and is sometimes faster) and the base64 encoding was to reduce the rather long length of SHA-512's hex encoding (which is 128-bytes rather than the 64-bytes which result from SHA-256's hex encoding).
Contributor
|
@abernix @jbaxleyiii nothing in flight that would be affected AFAIK, taking a look now to be sure. Thanks for the heads up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes: This changes the output format of the manifest generated by
queries:extractto be in a more evolvable format. Existing users of the manifest produced bymanifest.jsonshould take care to observe the new manifest format, as indicated by the top-level presence of aversionattribute (now1, previouslyundefined).In general, this just moves some bits of often repeated portions of the CLI into a unified location where they can be shared by more modules as we use more and more portions in multiple places.