Revert "Fall back to other methods of schema loading... (#533)#613
Merged
martijnwalraven merged 1 commit intomasterfrom Oct 23, 2018
Merged
Revert "Fall back to other methods of schema loading... (#533)#613martijnwalraven merged 1 commit intomasterfrom
martijnwalraven merged 1 commit intomasterfrom
Conversation
abernix
commented
Oct 4, 2018
| { url: dependency.schema }, | ||
| config.projectFolder | ||
| ); | ||
| } catch {} |
Member
Author
There was a problem hiding this comment.
Throwing away all errors which occur from the fetchSchema method buries not only just the mere failure to acquire the schema in some manner, but it also neglects to reveal very important information about HTTP transport errors, file system errors, GraphQL execution and more — all of which happen via fetchSchema!
There was a problem hiding this comment.
Faced this yesterday, because of this catch - SSL certificate error was swallowed.
Contributor
|
This makes sense given the difficulty of tracing the root error. Maybe a future change could handle this better by aggregating the individual errors when no available sources work for the returned error? But this looks good otherwise! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit b48e7bf.
As corroborated by the trending number of 👍 emotes on #560, this PR introduced a number of
trycatches which silenced relatively useful information from their tried operations. I'm happy to help figure out a better approach but since this seems to have caused many more problems than it solved, we should consider a different approach.cc @shadaj
Closes #560