Require client identity for registering operations#615
Merged
abernix merged 2 commits intoabernix/register-operationsfrom Oct 4, 2018
Merged
Conversation
added 2 commits
October 4, 2018 11:24
Operations needs to be attached to a specific client so this PR adds the ability to send a client name, client id, and client version to annoate the manifest of operations. This will make it much easier to validate schema changes against registered queries and have a sane governace strategy
A point of clarity, client identifier is a better term for a value that can range from UUID, abritray strings, certs, and really anything else. Client Id was leading to confusion about the generation state and possible values (i.e. id's are typically a monotype)
abernix
approved these changes
Oct 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@abernix this adds client identity to the registration step!