Merged
Conversation
ghost
added
the
jbaxleyiii
reviewed
Oct 19, 2018
Contributor
jbaxleyiii
left a comment
jbaxleyiii
left a comment
There was a problem hiding this comment.
@trevor-scheer a couple questions!
Contributor
|
@trevor-scheer one thing else it would probably be better for this to be a command palate command instead of a click event on the status bar |
jbaxleyiii
suggested changes
Oct 19, 2018
Contributor
jbaxleyiii
left a comment
jbaxleyiii
left a comment
There was a problem hiding this comment.
After thinking about this, I do think we should make it a command palate vs click interaction
trevor-scheer
force-pushed
the
trevor/vscode-schema-switching
branch
from
3d340c2 to
6920ea2
Compare
Contributor
Author
|
@jbaxleyiii command palette change: 6920ea2 |
jbaxleyiii
approved these changes
Oct 19, 2018
Enable developing against different schema tags by allowing the user to choose a tag from a dropdown.
… combine requests for gathering engine data.
trevor-scheer
force-pushed
the
trevor/vscode-schema-switching
branch
from
6920ea2 to
91fbed1
Compare
shadaj
reviewed
Oct 19, 2018
| this._onSchemaTags && this._onSchemaTags(this.schemaTags); | ||
| }) | ||
| .catch(error => { | ||
| console.error(error); |
Contributor
There was a problem hiding this comment.
Is this an error that should be send to the loading handler? Otherwise I think the the indicator would get stuck.
abernix
added a commit
that referenced
this pull request
Nov 27, 2018
It appears that the original necessity for `tsc-watch` was introduced through new usage within `npm-scripts` commands in #632. Since that usage is no longer present (at least partially removed via 5f287d9), this dependency should no longer be necessary either. This is relatively urgent since `tsc-watch` includes the `event-stream` npm package as a transitive dependency and that package is demonstrably vulnerable: Ref: dominictarr/event-stream#116 cc @martijnwalraven @jbaxleyiii @trevor-scheer @hwillson
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
--tagflag.For context:
Schemas can be "branched" in a similar way that one might make a branch in a git repo. This concept allows developers to publish different "branches" (tags) of a schema to engine. Publishing a new tag to engine makes the new introspection available to a client, in this case, VSCode.
The result here is that an extension user can switch tags on the fly and expect all the benefits that an introspection provides: autocomplete, syntax errors, and other relevant information specific to that tag.