Warn on GraphQL parser exceptions#642
Merged
jbaxleyiii merged 1 commit intoapollographql:masterfrom Nov 14, 2018
Merged
Conversation
Fix silent parsing failure When GraphQL `parse` fails to parse a file errors are silently ignored. Was having an issue with a whitespace character in one of our `.graphql` files which was rather difficult to trace.
|
@hekard2l: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
Contributor
|
@hekard2l this is awesome! Thank you so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When GraphQL
parsefails to parse file(s) errors are silently ignored.Was having an issue with a whitespace character in one of our
.graphqlfiles which was rather difficult to trace. This character is added as a result of saving the file in XCode, so it'd be a common use case.Example:
The stacktrace isn't useful, but
e.messagedoes not contain the filename, line number and preview.