filter objects in getter to only include known typenames#656
Merged
jbaxleyiii merged 1 commit intoapollographql:masterfrom Aug 5, 2019
unitedwardrobe:filter-unknown-typenames
Merged
filter objects in getter to only include known typenames#656jbaxleyiii merged 1 commit intoapollographql:masterfrom unitedwardrobe:filter-unknown-typenames
jbaxleyiii merged 1 commit intoapollographql:masterfrom
unitedwardrobe:filter-unknown-typenames
Conversation
Contributor
Author
|
Ping ✨ |
Contributor
Author
|
Anyone? |
Contributor
|
@koenpunt apologies for the lack of response here. Unfortunately, this is code I don't know how to review and we don't currently have anyone available who does. As a side note, we're hiring a mobile engineer! |
designatednerd
approved these changes
Jul 26, 2019
Contributor
designatednerd
left a comment
designatednerd
left a comment
There was a problem hiding this comment.
LGTM! I'll get someone with TS experience to take a look at this as well
jbaxleyiii
approved these changes
Aug 5, 2019
abernix
approved these changes
Aug 5, 2019
Contributor
Author
|
It took some time, but I'm glad it's merged now! 🚀 |
Contributor
|
D'oh! This is causing some issues with our sample project, looking into a fix |
designatednerd
added a commit
that referenced
this pull request
Aug 7, 2019
Merged
essaji
pushed a commit
to essaji/apollo-tooling
that referenced
this pull request
Aug 25, 2019
* Revert changes from apollographql#656 which were causing build issues on iOS * Update changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a solution to the problem described here:
I'm not sure if this is the only place where this filtering has to be done, but this at least fixes it for our use case.