Rewrite Scala codegen to handle all data as traits#686
Merged
Conversation
shadaj
changed the title
shadaj
added
🎉 feature
JakeDawkins
pushed a commit
that referenced
this pull request
Jan 16, 2019
* Rewrite Scala codegen to return data as traits * Fix possible types check * Update unit tests * Properly handle deep fields inside fragments * Emit Scala types for variables * Fix default value * Fix input tracking * Fix variables input type * Use library defined optional types * Update snapshots * Update snapshots * Completely drop case classes from codegen * Don't hardcode None for OptionalInput * Minimize diff relative to master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drastically improves performance and ease of use when working with fragments.