Skip to content

New Feature: Add Python document extractor to the language server#693

Merged
martijnwalraven merged 1 commit intoapollographql:masterfrom
patrys:add-python-document-extractor
Nov 13, 2018
Merged

New Feature: Add Python document extractor to the language server#693
martijnwalraven merged 1 commit intoapollographql:masterfrom
patrys:add-python-document-extractor

Conversation

@patrys
Copy link
Copy Markdown
Contributor

@patrys patrys commented Nov 13, 2018

Python does not have tagged templates but it's safe to assume that the user will use a function named gql() to wrap document literals in code.

There is currently no GitHub issue tracking this feature, it was however discussed on the Apollo Slack.

@ghost ghost added the 🎉 feature New addition or enhancement to existing solutions label Nov 13, 2018
patrys added a commit to patrys/apollo-tooling that referenced this pull request Nov 13, 2018
This depends on the language server supporting Python (PR apollographql#693) for IntelliSense.

Apollo config defaults to JS/TS files only, so it's required to add `*.py` to
`apollo.config.js` under `client.includes` before completion/validation starts
to work.
Python does not have tagged templates but it's safe to assume that the user
will use a function named `gql()` to wrap document literals in code.
@patrys patrys force-pushed the add-python-document-extractor branch from 9d75522 to 6623ca0 Compare November 13, 2018 13:21
@martijnwalraven martijnwalraven merged commit 5f3fb63 into apollographql:master Nov 13, 2018
martijnwalraven pushed a commit that referenced this pull request Nov 13, 2018
This depends on the language server supporting Python (PR #693) for IntelliSense.

Apollo config defaults to JS/TS files only, so it's required to add `*.py` to
`apollo.config.js` under `client.includes` before completion/validation starts
to work.
@patrys patrys deleted the add-python-document-extractor branch November 13, 2018 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎉 feature New addition or enhancement to existing solutions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants