pass directives from schema modules through buildServiceDefinition

[tgerk]

Directive definitions were discarded when merging types from modules in buildServiceSchema. The fix is nearly trivial, because Kind.DIRECTIVE_DEFINITION is a unique case that is neither a schema definition nor a type definition.

[apollo-cla]

@tgerk: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

[martijnwalraven]

Thanks for looking into this! I don't think this is the right solution though, because directives live in their own namespace, and adding them to typeDefinitionsMap clashes with similarly named type definitions.

I think the solution is to keep a separate list of directiveDefinitions, similar to what buildASTSchema does (see here).

Also, it seems this PR needs to be rebased, because it includes unrelated commits made by others.

[tgerk]

Pardon the confusion, I have rebased my branch from the tagged release to master branch.

I've also segregated the directives from types as you pointed out.

[trevor-scheer]

Aside from my single comment, this LGTM. Would like @martijnwalraven to give final pass and approval.

[tgerk]

Changes have been made to variable names and to behavior as suggested, including tests.

• duplicated directive declarations within a module or in different modules are detected and reported
• directives and type definitions are used together in constructing the resulting schema

[martijnwalraven]

Thanks for opening this PR and making the changes! (The CI failures are unrelated I think.)