Add support for queries, includes, and excludes flags for codegen#733
Merged
trevor-scheer merged 2 commits intomasterfrom Nov 21, 2018
Merged
Add support for queries, includes, and excludes flags for codegen#733trevor-scheer merged 2 commits intomasterfrom
trevor-scheer merged 2 commits intomasterfrom
Conversation
After the overhaul, support for the queries flag in codegen was altered. Restore previous behavior and add includes and excludes flags. Note: excludes patterns don't work in watch mode due to a limitation with Gaze, the filewatcher we're using.
trevor-scheer
force-pushed
the
trevor/fix-queries-flag
branch
from
f6e5f5a to
22d2bc0
Compare
martijnwalraven
approved these changes
Nov 21, 2018
Contributor
martijnwalraven
left a comment
martijnwalraven
left a comment
There was a problem hiding this comment.
Looks good to me! Let's revisit watch mode later. We may want to switch to a different file watcher and integrate watching more closely with the language server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the overhaul, support for the queries flag in codegen was altered. This restores previous behavior and add includes and excludes flags.
Note: excludes patterns don't work in watch mode due to a limitation with
Gaze, the file watcher we're using.
Tested:
includes,includes + excludes,querieswatchflag