Skip to content

Fix --key flag/env variable precendece#770

Merged
jbaxleyiii merged 2 commits intomasterfrom
flag-precedence
Nov 30, 2018
Merged

Fix --key flag/env variable precendece#770
jbaxleyiii merged 2 commits intomasterfrom
flag-precedence

Conversation

@JakeDawkins
Copy link
Copy Markdown
Contributor

@JakeDawkins JakeDawkins commented Nov 30, 2018

Problem

  • When running the Apollo CLI from a repo that has an apollo.config.js file, the config's engine service name always took precedence over a passed in --key flag and/or environment variables.

Solution

  • Make sure that the config loader uses the proper service/client name.
  • If there's a name passed in (from .env file or from flags), it should overwrite the client.service/service.name from the loaded file.

@jbaxleyiii jbaxleyiii merged commit ebfd985 into master Nov 30, 2018
@jbaxleyiii jbaxleyiii deleted the flag-precedence branch November 30, 2018 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants