Resolve Windows FS Issues by trevor-scheer · Pull Request #810 · apollographql/apollo-tooling

trevor-scheer · 2018-12-06T20:36:58Z

This PR should resolve the codegen issues on Windows that have been reported in the long-running codegen issue thread #719

Thanks to @patrys for really digging in and suggesting some changes!

Pending set up of Appveyor, I'd appreciate if any of our Windows users could test out this change.
cc: @chenglabs @ZenSoftware @jbaxleyiii @patrys

jbaxleyiii

This looks good, I'll try it out on windows and let you know!

jbaxleyiii · 2018-12-07T00:38:06Z

      filepath === process.cwd()
-        ? `file://${filepath}`
-        : `file://${parse(filepath).dir}`;
+        ? Uri.file(filepath)


jbaxleyiii · 2018-12-07T00:38:17Z

 }"
 `;

-exports[`client:codegen writes TypeScript global types to a custom path when globalTypesFile is set 1`] = `


Why was this removed?

This was a result of muddying up, then deleting, and finally regenerating this test snap. The test is skipped, so the snap is obsolete. Side note: doesn't jest normally find these and remove them with -u?

Can totally revert this change!

steabert · 2018-12-18T09:08:50Z

Is there a way to apply this fix easily while waiting for the next apollo version? I'm not familiar with specifying a github url for packages belonging to a monorepo, maybe someone here knows a way to do that?

TimKnipe · 2018-12-18T09:40:49Z

What I've been doing is go into node_modules/apollo/lib/Command.js and find the 2 "file://" references and change them to "file:///"

Yeah, i have to redo this every time i add or update packages as it gets overwritten.

treylon · 2018-12-19T10:24:51Z

@steabert You can also use the linux subsystem for windows for now and prefix your script generation command with wsl to execute it via the shell. Works like a charm for me without having to edit any files. If you have not enabled it see here: https://docs.microsoft.com/en-us/windows/wsl/install-win10

wsl yarn run [generation-script-name]

jhalborg · 2019-01-07T14:34:41Z

Could this please be prioritized soon? We're holding off on upgrading to 2.0+ pending this change, which again halts further work using some new Apollo Platform features.

* Convert "string" URIs to actual Uri objects * Don't manually build URIs, hand off to Uri constructor instead * Switch usages of path.relative to path.posix.relative

jhalborg · 2019-01-16T09:09:21Z

Wohoo @JakeDawkins ! 🙌

When can we expect this on NPM, and which version number should we look for?

* Resolve Windows FS Issues * Convert "string" URIs to actual Uri objects * Don't manually build URIs, hand off to Uri constructor instead * QoL debug script and snapshot update * Updates snapshots * Add windows node 10 job to pipeline config

JakeDawkins · 2019-01-16T16:57:56Z

@jhalborg @steabert @TimKnipe @treylon @patrys Thanks for all the feedback! These changes should be live now in version 2.2.0 of the cli!

JakeDawkins · 2019-01-16T18:03:06Z

@jhalborg @steabert @TimKnipe @treylon @patrys sorry, I had to unpublish because of a config issue. I'll try to get it back out today!

jhalborg · 2019-01-18T10:27:15Z

@JakeDawkins - Any news?

NateScarlet · 2019-01-23T02:47:32Z

Not work with apollo/2.3.0 win32-x64 node-v10.9.0
Still got error when mkdir, added variable log in apollo\lib\generate.js

E:\Dev\taskboard [master ↑1 +0 ~76 -0 | +0 ~3 -0 !]> npx apollo client:codegen --globalTypesFile frontend/src/types/graphql-global.ts --target typescript types
// rootPath: E:\Dev\taskboard
// sourcePath: file:///e%3A/Dev/taskboard/frontend/src/graphql/acceptanceNode.gql
// toPath(sourcePath): /e:/Dev/taskboard/frontend/src/graphql/acceptanceNode.gql
  √ Loading Apollo Project
  × Generating query files with 'typescript' target
    → ENOENT: no such file or directory, mkdir '..\..\e:\Dev\taskboard\frontend\src\graphql\types'
// rootPath: E:\Dev\taskboard
// sourcePath: file:///e%3A/Dev/taskboard/frontend/src/graphql/acceptanceNode.gql
// toPath(sourcePath): /e:/Dev/taskboard/frontend/src/graphql/acceptanceNode.gql
(node:10344) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, mkdir '..\..\e:\Dev\taskboard\frontend\src\graphql\types'
    at Object.mkdirSync (fs.js:729:3)
    at generatedFiles.forEach (E:\Dev\taskboard\node_modules\apollo\lib\generate.js:101:38)
    at Array.forEach (<anonymous>)
    at Object.generate [as default] (E:\Dev\taskboard\node_modules\apollo\lib\generate.js:94:28)
    at write (E:\Dev\taskboard\node_modules\apollo\lib\commands\client\codegen.js:64:54)
    at GraphQLClientProject.project.onDiagnostics [as _onDiagnostics] (E:\Dev\taskboard\node_modules\apollo\lib\commands\client\codegen.js:81:29)
    at GraphQLClientProject.validate (E:\Dev\taskboard\node_modules\apollo-language-server\lib\project\client.js:122:18)
    at GraphQLClientProject.validateIfNeeded (E:\Dev\taskboard\node_modules\apollo-language-server\lib\project\base.js:127:14)
    at Timeout.setTimeout [as _onTimeout] (E:\Dev\taskboard\node_modules\apollo-language-server\lib\project\base.js:119:22)
    at ontimeout (timers.js:424:11)

JakeDawkins · 2019-01-23T16:19:47Z

@jhalborg Sorry for not responding. My notification settings are messed up 🙃

I released these changes with 2.3.0, but you may run into @NateScarlet's issue. I'll look into that and maybe cut a patch release for it if needed

Patch for comment on #810

jhalborg · 2019-01-26T16:24:58Z

@JakeDawkins That would be great!

JakeDawkins · 2019-01-26T16:43:46Z

@jhalborg 2.3.1 should have the fixes for the issue mentioned above!

trevor-scheer requested review from JakeDawkins and jbaxleyiii December 6, 2018 20:36

jbaxleyiii reviewed Dec 7, 2018

View reviewed changes

trevor-scheer mentioned this pull request Dec 9, 2018

"No operations or fragments" error during client:codegen #719

Closed

JakeDawkins changed the base branch from master to pipelines January 11, 2019 18:43

trevor-scheer added 2 commits January 14, 2019 13:53

Resolve Windows FS Issues

7105b73

* Convert "string" URIs to actual Uri objects * Don't manually build URIs, hand off to Uri constructor instead * Switch usages of path.relative to path.posix.relative

QoL debug script and snapshot update

8fd101a

JakeDawkins force-pushed the trevor/fix-windows-paths branch from a476603 to 8fd101a Compare January 14, 2019 21:53

JakeDawkins added 4 commits January 14, 2019 13:56

removed posix

bef16e4

fixes snapshots

d59a702

add windows node 10 and remove linux jobs

88027cd

update azure script

732dee0

JakeDawkins merged commit 02f0180 into pipelines Jan 15, 2019

JakeDawkins deleted the trevor/fix-windows-paths branch January 16, 2019 16:58

NateScarlet mentioned this pull request Jan 23, 2019

Correct path build for windows #917

Merged

JakeDawkins pushed a commit that referenced this pull request Jan 24, 2019

Correct path build for windows (#917)

5050172

Patch for comment on #810

Conversation

trevor-scheer commented Dec 6, 2018

Uh oh!

jbaxleyiii left a comment

Choose a reason for hiding this comment

Uh oh!

jbaxleyiii Dec 7, 2018

Choose a reason for hiding this comment

Uh oh!

jbaxleyiii Dec 7, 2018

Choose a reason for hiding this comment

Uh oh!

trevor-scheer Dec 7, 2018

Choose a reason for hiding this comment

Uh oh!

steabert commented Dec 18, 2018

Uh oh!

TimKnipe commented Dec 18, 2018

Uh oh!

treylon commented Dec 19, 2018

Uh oh!

jhalborg commented Jan 7, 2019

Uh oh!

jhalborg commented Jan 16, 2019

Uh oh!

JakeDawkins commented Jan 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JakeDawkins commented Jan 16, 2019

Uh oh!

jhalborg commented Jan 18, 2019

Uh oh!

NateScarlet commented Jan 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JakeDawkins commented Jan 23, 2019

Uh oh!

jhalborg commented Jan 26, 2019

Uh oh!

JakeDawkins commented Jan 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

JakeDawkins commented Jan 16, 2019 •

edited

Loading

NateScarlet commented Jan 23, 2019 •

edited

Loading