[AT-10] Add helpful errors / messaging around config files#897
Merged
JakeDawkins merged 14 commits intomasterfrom Jan 30, 2019
Merged
[AT-10] Add helpful errors / messaging around config files#897JakeDawkins merged 14 commits intomasterfrom
JakeDawkins merged 14 commits intomasterfrom
Conversation
trevor-scheer
force-pushed
the
trevor/config-helpful-messaging
branch
from
0a7ce7f to
17a3c47
Compare
JakeDawkins
reviewed
Jan 22, 2019
JakeDawkins
suggested changes
Jan 22, 2019
Contributor
JakeDawkins
left a comment
JakeDawkins
left a comment
There was a problem hiding this comment.
Looks great overall! Just a could questions :)
This comment has been minimized.
This comment has been minimized.
trevor-scheer
force-pushed
the
trevor/config-helpful-messaging
branch
from
c15797b to
8baa4d5
Compare
trevor-scheer
changed the title
or when errors are found. Add fn to workspace for reloading a project with a given config URI.
Update error handling from within the server (send as message). This message can be listened for and handled by the consumer. Update statusBar to reflect new possible "warning" states.
…hen no config file is found.
Co-Authored-By: trevor-scheer <trevor.scheer@gmail.com>
JakeDawkins
force-pushed
the
trevor/config-helpful-messaging
branch
from
8baa4d5 to
39ebe17
Compare
JakeDawkins
approved these changes
Jan 30, 2019
Contributor
|
:yolo: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds new warning states and communication within the extension in order to help users resolve config issues more easily and know when there's a problem.
Also included with this PR is a bit of a shift in how errors are handled. After speaking with James about it, we both agreed that this would be a scalable approach that will work well with clients consuming the language server or using its parts programmatically.