Fix configuration loading and schema tag support#925
Merged
trevor-scheer merged 5 commits intomasterfrom Jan 25, 2019
Merged
Conversation
* Cosmiconfig looks UP for configs from a provided config. This means that any package.json could send cosmiconfig to the parent - causing lots of dir weirdness. Filter out package.json files that don't contain an apollo config. Update apollo.config.js to point to engine@master * Incidentally found and fixed a bug related to providing the schema tag via the @. The @tag is no longer left behind when it's provided.
…provided. Priority for choosing the tag name should be: flag -> config -> "current" With a default flag set, that default would always defeat the tag provided via config.
trevor-scheer
force-pushed
the
trevor/fix-config-loading
branch
from
71e965a to
c0d20ce
Compare
trevor-scheer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets the extension and configuration back in a better state. No promises that all monorepo issues are resolved, but these fix blocking bugs (bugs which, ironically, prevent us from being able to properly use the extension on the tooling repo).
I found these bugs when trying to update our config to use service:
engine@master.any package.json (in our case, one for each repo - none of which need an apollo config) could send
cosmiconfig to the parent - causing lots of dir weirdness. Filter out package.json files that don't
contain an apollo config.
Update our apollo.config.js to point to
engine@masterlonger left behind when it's provided.