[AT-36] Improve client:check output#934
Merged
trevor-scheer merged 3 commits intomasterfrom Jan 29, 2019
Merged
Conversation
Contributor
|
This is so incredible |
JakeDawkins
reviewed
Jan 29, 2019
JakeDawkins
approved these changes
Jan 29, 2019
Contributor
JakeDawkins
left a comment
There was a problem hiding this comment.
This looks really great!! Can you add a changelog entry for these changes? :)
There should be 2 entries: one for the language server, and one for the cli
…ion. * Leverage new mutation to provide file specific data for validation errors. * Display messages grouped by query, with a clickable link to each query
3f28e3e to
78aa056
Compare
78aa056 to
44d8d27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sidenote, this ^ feels pretty good but we can improve
As far as flow-y errors go, I know we can get there but as I explored the idea, it started to feel like a solid amount of work in and of itself. The short explanation is that we can currently get close, but since we don't store the raw document in the data model, we lose the source location data we would need to give a correct location.
Some more explanation: what we do now is pass around an actual
Documentandprint()it when it's time to pass the string to the backend - we can't use this because the source formatting is lost. Sooo, when we want to perfect this, we'll need to pass that information around as well and do a little bit of math with the validation results that come back from the server.