[AT-34] Fixed client identity reporting#940
Merged
JakeDawkins merged 3 commits intomasterfrom Feb 12, 2019
Merged
Conversation
JakeDawkins
requested review from
jbaxleyiii and
trevor-scheer
as code owners
JakeDawkins
changed the title
trevor-scheer
approved these changes
Jan 29, 2019
| - `apollo-language-server` | ||
| - Fix language server mis-reporting client identity for schema loading operation [#940](https://github.com/apollographql/apollo-tooling/pull/940) | ||
| - `vscode-apollo` | ||
| - Fix graphql comments not being highlighted correctly [#907](https://github.com/apollographql/apollo-tooling/pull/907) |
Contributor
There was a problem hiding this comment.
Thanks for adding this one in 😄
JakeDawkins
force-pushed
the
jake/reporting
branch
from
e4400b6 to
72a1d8f
Compare
jbaxleyiii
approved these changes
Feb 11, 2019
jbaxleyiii
approved these changes
Feb 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
One operation (
getSchemaByTag) wasn't reporting the correct client to engine, so it was showing up as the default (Apollo-language-server).Cause
The
EngineSchemaProvidercreated an instance ofApolloEngineClient, but wasn't passing it theclientIdentity(because it didn't have that).Fix
I added an item to the constructor of
EngineSchemaProviderfor client identity and made sure it was being passed throughschemaProviderFromConfig