Skip to content

improve vscode marketplace appearance#942

Merged
JakeDawkins merged 6 commits intomasterfrom
jake/marketplace
Feb 26, 2019
Merged

improve vscode marketplace appearance#942
JakeDawkins merged 6 commits intomasterfrom
jake/marketplace

Conversation

@JakeDawkins
Copy link
Copy Markdown
Contributor

@JakeDawkins JakeDawkins commented Jan 29, 2019

resolves #816

screen shot 2019-01-29 at 5 25 58 pm

🔼 (what the marketplace header looks like now)


screen shot 2019-01-29 at 5 13 10 pm

🔼 (what the marketplace header would look like with these changes)

What I did:

  • Updated marketplace readme to more-or-less match the proposed changes to the editor docs
  • Changed the banner color for the extension to be blue
  • Changed the icon to be white on blue instead of teal

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)

Comment thread packages/vscode-apollo/README.md Outdated
Comment thread packages/vscode-apollo/README.md Outdated
Comment thread packages/vscode-apollo/README.md
Comment thread packages/vscode-apollo/README.md Outdated
Comment thread packages/vscode-apollo/README.md Outdated
Comment thread packages/vscode-apollo/README.md Outdated
Comment thread packages/vscode-apollo/README.md Outdated
Comment thread packages/vscode-apollo/README.md Outdated
<img src="./images/marketplace/jump-to-def.gif" width="80%" style="margin: 5%" alt="Using jump to definition on a fragment">

<h3 id="commands">Apollo commands</h3>
The VS Code extension integrates with the VS Code command palate and provides two commands currently:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list is another "thing" that would probably become dated as we change and add commands. Though we don't currently have a docs "source of truth" the way we do for config, so go with what you think is best here...I don't feel too strongly.

Comment thread packages/vscode-apollo/README.md Outdated
Comment thread packages/vscode-apollo/README.md Outdated
@JakeDawkins JakeDawkins merged commit 6f3d441 into master Feb 26, 2019
@JakeDawkins JakeDawkins deleted the jake/marketplace branch February 26, 2019 15:49
@mountainash
Copy link
Copy Markdown

@JakeDawkins - just wanted to point out a super small typo (but could be a big "copy & paste" timesaver)... missing a comma at https://github.com/apollographql/apollo-tooling/blame/master/packages/vscode-apollo/README.md#L84

I know I could fork, commit, PR, etc. but for a single , I thought it's less work for you (as an active committer) to work it into your next update.

trevor-scheer added a commit that referenced this pull request Jun 8, 2021
Fix missing comma in code example, as pointed out by @mountainash
#942 (comment)
@trevor-scheer
Copy link
Copy Markdown
Contributor

Thanks @mountainash! We don't publish the extension often, but this fix will land the next time we do.
fc415b5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Extension Page

3 participants