Improve Scala codegen to make results feel more like case classes#943
Merged
trevor-scheer merged 2 commits intoapollographql:masterfrom Feb 5, 2019
Merged
Conversation
shadaj
changed the title
trevor-scheer
approved these changes
Jan 31, 2019
Contributor
trevor-scheer
left a comment
trevor-scheer
left a comment
There was a problem hiding this comment.
LGTM!
We're back to keeping up the changelog, so if you don't mind adding an entry for apollo-codegen-scala in the Upcoming section that would be awesome. Thanks!
Caveat: I don't know Scala. Once you resolve my one little question I'll merge and publish 👍
Contributor
Author
|
Huh, the Azure tests are failing now, but seems unrelated to the changes in this PR. |
Contributor
|
Re-ran the pipeline, looks like we're good. I'll merge this in the morning. Thanks again! |
shadaj
force-pushed
the
scala-codegen-case-class-like
branch
from
60532be to
935109b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change to use traits left some codebases pretty source incompatible, as they depended on APIs that are automatically generated for case classes. This adjusts the codegen to generate similar APIs so that query results have the feel of being case classes without the performance overhead.