Merged
Conversation
evans
force-pushed
the
evans/remove-deprecated
branch
2 times, most recently
from
7d5ac71 to
6566ccc
Compare
This removes unused and undocumented code that is a holdover from apollo@1 and tech debt. Since `apollo` is a commandline tool, this code should not be used outside of Apollo's internal Platform tools, so I suggest that the code be removed without a major version bump
evans
force-pushed
the
evans/remove-deprecated
branch
from
6566ccc to
312e006
Compare
Contributor
|
Thanks for the cleanup 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes unused and undocumented code that is a holdover from
apollo@1 and tech debt. Since
apollois a commandline tool, this codeshould not be used outside of Apollo's internal Platform tools, so I
suggest that the code be removed without a major version bump
TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.