Skip to content

Fix inline graphql highlighting in Vue <script>#981

Merged
trevor-scheer merged 2 commits intoapollographql:masterfrom
octref:octref/vue-inline-graphql
Feb 7, 2019
Merged

Fix inline graphql highlighting in Vue <script>#981
trevor-scheer merged 2 commits intoapollographql:masterfrom
octref:octref/vue-inline-graphql

Conversation

@octref
Copy link
Copy Markdown
Contributor

@octref octref commented Feb 6, 2019

Reference:

vuejs/vetur#701

(Thanks to @flakeparadigm for the original fix and permission to use it)

Pre:

image

Now:

image

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@apollo-cla
Copy link
Copy Markdown

@octref: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@trevor-scheer
Copy link
Copy Markdown
Contributor

This is excellent, thanks to both of you for the contribution! 🎉(cc: @flakeparadigm)

We'd love to expand support for Vue across all of our tooling. Would either or both of you be interested in contributing to the CLI? Adding support for our client commands (codegen, push, check) would be amazing! I'd be happy to provide some guidance and work with you if that sounds interesting 😄

@trevor-scheer trevor-scheer merged commit d5cc7f1 into apollographql:master Feb 7, 2019
@octref
Copy link
Copy Markdown
Contributor Author

octref commented Feb 7, 2019

I wouldn't have much time to contribute, but if there something I can do in https://github.com/vuejs/vetur let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants