This repository was archived by the owner on Apr 14, 2023. It is now read-only.
Update client awareness docs to use latest AC#258
Merged
Conversation
evans
requested review from
abernix,
daniman,
hwillson,
peggyrayzis and
zionts
Contributor
Author
|
Currently this needs to wait on Apollo-server@2.2.3 for apollographql/apollo-server#1960 |
hwillson
approved these changes
Nov 21, 2018
hwillson
left a comment
hwillson
left a comment
Member
There was a problem hiding this comment.
The AC changes look good @evans! I'm new to these docs, so I'm probably just missing something, but is there any reason why we need to still show the HttpLink approach in Advanced Setup? Or is the intent to just show that there is an alternative way to get client info passed in and handled? Regardless, it all works so 👍.
evans
commented
Nov 26, 2018
Contributor
Author
|
@hwillson I kept it in there in case we need to point someone towards using/implementing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We update the setup docs to use the latest Apollo Client constructor