v1.19.1: (Fed v2.4.6) Cannot add fragment of condition "..." (runtimes: [...]) to parent type "..." (runtimes: ...)

[Meemaw]

Describe the bug
Trying to upgrade from 1.15.1 to 1.19.1 and getting this error on a query;

{"errors":[{"message":"value retrieval failed: router bridge error: the deno runtime raised an error: `request: couldn't receive response couldn't deserialize payload `17165114415491825123`: `deno: couldn't deserialize response : `Error(\"invalid neither null nor empty object: found Object {\\\"code\\\": String(\\\"QUERY_PLANNING_FAILED\\\"), \\\"exception\\\": Object {\\\"stacktrace\\\": Array [String(\\\"Cannot add fragment of condition \\\\\\\"AssetBundleType\\\\\\\" (runtimes: [AssetBundleType]) to parent type \\\\\\\"AssetType\\\\\\\" (runtimes: AssetType)\\\")]}}\", line: 0, column: 0)``.`","extensions":{"code":"INTERNAL_SERVER_ERROR"}}]}

Any idea what this might be related to? The queries/schema is quite complicated, but can provide it if the above message doesn't provide enough info.

To Reproduce
N/A

Expected behavior
Queries to work.

[abernix]

This looks a lot like the error produced in apollographql/federation#2596 which was meant to be fixed (and certainly was to the extent of the last reproduction we had!) with https://github.com/apollographql/federation/releases/tag/%40apollo%2Fquery-planner%402.4.6, which shipped with Router 1.19.1 thanks to #3135.

As with the last one, I'll transfer this over to the federation repository since they'll have to look at it on the query-planner side of things, but please do make sure you're on v1.19.1 (you said you were, but just want to double-check you hadn't paused on 1.19.0 or something 😄 ).

And of course, if there's any way you can come up with a minimal reproduction schema/query, I'm sure that would be helpful to that team. (If you're reporting that information to Studio, we can also access the full schema/operation from your account with your consent if you want to open a ticket with our support team.)

[Meemaw]

This looks a lot like the error produced in apollographql/federation#2596 which was meant to be fixed (and certainly was to the extent of the last reproduction we had!) with https://github.com/apollographql/federation/releases/tag/%40apollo%2Fquery-planner%402.4.6, which shipped with Router 1.19.1 thanks to #3135.

As with the last one, I'll transfer this over to the federation repository since they'll have to look at it on the query-planner side of things, but please do make sure you're on v1.19.1 (you said you were, but just want to double-check you hadn't paused on 1.19.0 or something 😄 ).

And of course, if there's any way you can come up with a minimal reproduction schema/query, I'm sure that would be helpful to that team. (If you're reporting that information to Studio, we can also access the full schema/operation from your account with your consent if you want to open a ticket with our support team.)

Certainly on 1.19.1. Does version of federation Build Configuration matters? e.g 2.3 vs 2.4 (which seems to be in preview).

[abernix]

That shouldn't be a problem. Out of curiosity, are you encountering this with a Contract schema?

[Meemaw]

That shouldn't be a problem. Out of curiosity, are you encountering this with a Contract schema?

Not sure what that is. If its this -- https://www.apollographql.com/docs/graphos/delivery/contracts/ then no.

[marc-barry]

I'm wondering if #3133 (comment) this for us as well. v1.19.1 didn't fix the issue (or all issues). I'm going to have to weed through the cross-repo issues and see why we are still seeing issues.

[abernix]

It indeed appears it was only a partial fix. The Federation query planning team is investigating this and will provide an update — and a bug fix — soon. I'll pin this for now.

[abernix]

We'd appreciate confirmation from your end, but we believe this is fixed thanks to the update in https://github.com/apollographql/federation/releases/tag/%40apollo%2Fquery-planner%402.4.7 which shipped in https://github.com/apollographql/router/releases/tag/v1.20.0. I'll close this for now, but please do report back if it continues to be problematic for you!