fix: removes unwrap from is_federated query#549
Merged
EverlastingBugstopper merged 1 commit intomainfrom May 19, 2021
Merged
Conversation
e39a361 to
ab4a4c5
Compare
JakeDawkins
approved these changes
May 18, 2021
lrlna
requested changes
May 18, 2021
ab4a4c5 to
f4dcaf6
Compare
lrlna
approved these changes
May 19, 2021
| }, | ||
| &client, | ||
| )?; | ||
| if is_federated { |
Contributor
Author
There was a problem hiding this comment.
this should be !is_federated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #548 by removing the
.unwrapcall in theis_federatedrun that occurs if anything goes wrong with the query (for instance, mistyping your graph name).This PR includes a few other refactors:
is_federatedcheck if the--convertflag is passed tosubgraph publish, removing the extra network hopis_federatedquery directly in therover_client::querymodules that need them, instead of inrovercode.RoverClientError::ExpectedFederatedGraphdirectly fromrover_clientinstead of constructing the error manually inrover--convert😄.ok_orAlso fixes #550