feat: Support log commands#309
Merged
mykola-mokhnach merged 3 commits intoappium:masterfrom Apr 25, 2025
Merged
Conversation
| }); | ||
|
|
||
| it('should throw an error when an invalid type is given', async function () { | ||
| await driver.getLogs('INVALID_LOG_TYPE').should.rejected; |
| @@ -0,0 +1,39 @@ | |||
| import _ from 'lodash'; | |||
| import { WindowsDriver } from '../driver'; | |||
There was a problem hiding this comment.
consider using import type if an identifier is only used for type declarations
mykola-mokhnach
approved these changes
Apr 25, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Apr 25, 2025
## [4.4.0](v4.3.1...v4.4.0) (2025-04-25) ### Features * Support log commands ([#309](#309)) ([b96b4b5](b96b4b5))
|
🎉 This PR is included in version 4.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thank you @kkb912002 Perhaps you'd also be interested in https://www.youtube.com/watch?v=mieajcgUn-k |
Author
Awesome 😮 |
KazuCocoa
added
size:M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codes from android(uiautomator2) and xcuitest drivers.
only support 'server' type.
Server logs are being handled in the same way even if the drivers are different. Wouldn't it be possible to change the way they are processed to a method like the one used by the context API in plugins? For example, by consolidating the logs in the base driver's getLogTypes method with a structure like ['server', ...pluginResults, ...driverResults], server log handling could be done in one place within the base driver's getLogTypes and getLog methods.