Skip to content

fix: use full path instead of short path#327

Merged
KazuCocoa merged 1 commit intomasterfrom
fix-path
Oct 9, 2025
Merged

fix: use full path instead of short path#327
KazuCocoa merged 1 commit intomasterfrom
fix-path

Conversation

@KazuCocoa
Copy link
Copy Markdown
Member

#324

It looks like https://nodejs.org/api/os.html#ostmpdir on the user env returned short path -> #324 (comment)
https://en.wikipedia.org/wiki/8.3_filename

Then, the short path doesn't work with msiexec I guess, then we should resolve it as a full path.

I hope this will work on the user env

@mykola-mokhnach
Copy link
Copy Markdown

I assume #326 should be enough to address the issue. However, the above fix is also fine with me.

@KazuCocoa KazuCocoa merged commit 2d5fddb into master Oct 9, 2025
11 checks passed
@KazuCocoa KazuCocoa deleted the fix-path branch October 9, 2025 06:44
@KazuCocoa
Copy link
Copy Markdown
Member Author

Let me try this. #324 (comment) error was with msiexec.exe

github-actions bot pushed a commit that referenced this pull request Oct 9, 2025
## [5.0.4](v5.0.3...v5.0.4) (2025-10-09)

### Bug Fixes

* use real path ([#327](#327)) ([2d5fddb](2d5fddb))
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 9, 2025

🎉 This PR is included in version 5.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants